Shopify / react-native-skia

High-performance React Native Graphics using Skia
https://shopify.github.io/react-native-skia
MIT License
6.98k stars 452 forks source link

Crash on iOS version : 1.5.5 #2751

Closed hamdij0maa closed 2 days ago

hamdij0maa commented 2 days ago

`<Canvas mode="default" pointerEvents="none" style={themeStyles.box('absoluteFillObject', 'dark')} collapsable={false}>

</Canvas>`
wcandillon commented 2 days ago

Can you give me more information on how to reproduce the issue? Helpful things would include:

drookyn commented 2 days ago

Same on version 1.5.4. Error could be RNSKIA: Could not retrieve drawable from CAMetalLayer. Simulator just freezes. No problems with 1.5.3 (coming from 1.5.0).

Device: iPhone 15 Pro

wcandillon commented 2 days ago

@drookyn the error seems to make sense based on changes we have made, would you have a standalone example that allow to reproduce the crash?

hamdij0maa commented 2 days ago
drookyn commented 2 days ago

@wcandillon not on the fly. Is hamdij0maa's example enough if its reproducible?

wcandillon commented 2 days ago

@drookyn no we have the example app + e2e test suite that pass, I'd be curious to get a sense of the condition that can create this error.

hamdij0maa commented 2 days ago

changing the canvas style from : absoluteFillObject: { ...StyleSheet.absoluteFillObject, top: 0, left: 0, right: 0, bottom: 0, }, to : absoluteFillObject: { height: SIZES.screenHeight, width: SIZES.screenWidth, },

-- height , width if not set => causes the crash

wcandillon commented 2 days ago

Thanks a lot @hamdij0maa I was able to reproduce the crash and now submitting a fix for it.

hamdij0maa commented 2 days ago

@wcandillon thank you 🙏🏼 🚀

github-actions[bot] commented 2 days ago

:tada: This issue has been resolved in version 1.5.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

hamdij0maa commented 1 day ago

@wcandillon installed 1.5.6 , instant crash will lyk once issue found, iOS Simulator, version 1.5.6