Add threading boundaries on SkImage

Shopify / react-native-skia

High-performance React Native Graphics using Skia

https://shopify.github.io/react-native-skia

MIT License

6.98k stars 452 forks source link

Add threading boundaries on SkImage #2761

Closed wcandillon closed 4 hours ago

wcandillon commented 14 hours ago

Add thread boundaries on images that could be used in a different thread than the one they were created on. The solution is to use the graphic context available in the thread instead of using the "saved" within the image. Skia now has a SK_IMAGE_READ_PIXELS_DISABLE_LEGACY_API that helps with catching these (however APIs like makeImageSnapshot(GrDirectContext* gr = nullptr) cannot be caught by the flag).

github-actions[bot] commented 3 hours ago

:tada: This PR is included in version 1.5.8 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: