search

Shopify / react-native-skia

High-performance React Native Graphics using Skia
https://shopify.github.io/react-native-skia
MIT License
6.95k stars 447 forks source link

Android: Add support for Fabric / new architecture #676

Closed chrfalch closed 1 year ago

chrfalch commented 2 years ago

See #387

SVossMcK commented 1 year ago

Has anyone made progress migrating this library to Fabric or can I help in anyway? I'm using version 0.1.158 and it still throws the "unimplemented component" error when rendering a canvas. Unfortunately we have no choice but to use the Fabric architecture and we would really like to use this library but cannot seem to get it working with Fabric. Does anyone have any more information on this topic?

bryanmehall commented 1 year ago

Are there any updates on this? I just upgraded to Fabric on the new architecture and the the Skia components are breaking on Android. RN 0.71 makes the new architecture upgrade much easier so I imagine that a lot of apps are going to migrate soon.

LazloN5 commented 1 year ago

Any news ? :)

kibiz0r commented 1 year ago

I haven't seen many people talking about it, but there is an interop layer for the legacy arch now. https://github.com/reactwg/react-native-new-architecture/discussions/135

I don't know if it's practical for this lib or not, but if anyone is desperate to get the rest of their project on Fabric while still using Skia, I'd love to hear how it goes.

If it works alright, maybe we could get a "Fabric-compatible" release ahead of real Fabric support?

kylegillen commented 1 year ago

Totally understand this project has a lot of moving parts and paying supporters get priority, as has been stated already.

Having said that, for teams wanting to adopt the new arch, could a maintainer weigh-in on what a timeline for RN Skia supporting it may be?

Weeks? Months? Years?

Just so we can move forward with using it or not :) Thanks.

erie-e9 commented 1 year ago

I just tested it with Hermes enabled and using: -@shopify/react-native-skia v0.1.213 -react v18.2.0 -react-native v0.72.6 For Android built, but getting next error on iOS platform

Captura de pantalla 2023-10-19 a la(s) 10 27 57 p m

Temporal fix, add next to react-native.config.js file:

Captura de pantalla 2023-10-21 a la(s) 3 59 15 p m

Note 1 for temporal fix: Only worked for Android. Note 2 for temporal fix: You might reinstall app after add fix.

okaybeydanol commented 1 year ago

I just tested it with Hermes enabled and using: -@shopify/react-native-skia v0.1.213 -react v18.2.0 -react-native v0.72.6 For Android built, but getting next error on iOS platform

Captura de pantalla 2023-10-19 a la(s) 10 27 57 p m

I'm having the same problem, I couldn't find how to solve it. Does anyone know?

okaybeydanol commented 1 year ago

Can I know if there is any progress on this?

JuanRdBO commented 1 year ago

I'd love Skia on the new arch!

okaybeydanol commented 11 months ago

@wcandillon Thank you, I'm trying it right away.