search

Shopify / remote-dom

MIT License
883 stars 57 forks source link

Re-evaluate when to flush `useEffect` updates for remote-ui/react reconciler #11

Closed lemonmade closed 8 months ago

lemonmade commented 4 years ago

Right now, we are flushing the updates basically right after React runs, without waiting to see what happens when the updates are flushed to the host. Need to decide whether this is correct (I would prefer to keep it if possible), or if there are expectations that would be violated and we need to instead move effects to be flushed close to when they would have been had this code run on the main thread instead.

lemonmade commented 8 months ago

We are no longer providing a custom React reconciler as part of refactoring remote-ui onto the DOM.