Shopify / response_bank

Simple response caching for Ruby applications
http://www.shopify.com
MIT License
135 stars 18 forks source link

browser can't decompress #37

Closed saiqulhaq closed 4 years ago

saiqulhaq commented 4 years ago

this gem was working fine, I was using this gem few months ago

but now I am getting this error:

image

it's like the body is dumped, but not rendered correctly on browser side I have tried few times to call render method in response_cache's block argument

rafaelfranca commented 4 years ago

What changed between now and a few months ago that made this issue start to occur? Have you upgraded the gem? If, yes, from which commit to what commit?

How can we reproduce the issue?

saiqulhaq commented 4 years ago

if have another rails 6 app that using this gem since beginning, and have no issue

maybe the issue is because Redis my old app that uses Rails 5 and Redis has this issue

it looks like Shopify support Memcached only

I use IdentityCache gem too, and it supports Memcached only

saiqulhaq commented 4 years ago

I've reading the source code, but still can't resolve this issue

finally today I created a controller concern that use same logic as this gem, but it's slower because it's not in middleware level