search

Shopify / response_bank

Simple response caching for Ruby applications
http://www.shopify.com
MIT License
135 stars 18 forks source link

Add node-local locks support in response bank #79

Closed drinkbeer closed 1 year ago

drinkbeer commented 1 year ago

Description

This PR aims to support node-local ephemral cache based locks in response bank.

casperisfine commented 1 year ago

Could you expand on what it's for, the advantages, etc?

casperisfine commented 1 year ago

Also you are linking from a public repo into two private issues.

grcooper commented 1 year ago

I don't think we need this in the response bank repo. Let's instead look at how we can solve this within our own repo, also as casper mentioned, let's remove the links to our private issues/prs.

drinkbeer commented 1 year ago

Could you expand on what it's for, the advantages, etc?

We are migrating the lock keys from remote cache to node-local ephemeral cache. We have a beta flag to enable/disable the feature. The beta flag is passed to the response_bank through env variable. This PR want to support the node-local page cache locks.

drinkbeer commented 1 year ago

Also you are linking from a public repo into two private issues.

Removed the links.

casperisfine commented 1 year ago

We are migrating the lock keys from remote cache to node-local ephemeral cache. We have a beta flag to enable/disable the feature. The beta flag is passed to the response_bank through env variable.

I see. Well as @grcooper mentioned, this lock is purely a concern of the host app, so you can implement it however you want there, I really don't think you need any change upstream.

drinkbeer commented 1 year ago

Closed this PR per https://github.com/Shopify/storefront-renderer/pull/20307.