Shopify / restyle

A type-enforced system for building UI components in React Native with TypeScript.
https://shopify.github.io/restyle/
MIT License
2.95k stars 133 forks source link

Improve fixture package scripts and add CI #217

Closed mattfrances closed 1 year ago

mattfrances commented 1 year ago

Description

Improves the fixture app's package scripts and adds CI.

The package scripts added are:

For CI, this PR adds pipelines to build the fixture's TypeScript code and build the Android app. We decided to not build the iOS app as it would take ~30mins (see time in flashlist for reference). Since updates to the app will generally not contain native code, this check is not entirely necessary and we will add it in the future if it does become needed.

Reviewers’ hat-rack :tophat:

  1. CI ✅
  2. Run the package scripts above in the root folder using yarn <command> and confirm that they all work properly

Screenshots or videos (if needed)

Checklist

mattfrances commented 1 year ago

The only thing, can we leave a comment or a decision log about skipping iOS build on CI? I could see future maintainers being confused by it.

Great point, added it in!