Shopify / restyle

A type-enforced system for building UI components in React Native with TypeScript.
https://shopify.github.io/restyle/
MIT License
2.86k stars 128 forks source link

Add missing typography properties #249

Closed mattfrances closed 1 year ago

mattfrances commented 1 year ago

Description

There are a few of React Native's Text Style Props missing from our typography restyle functions. As a result, some text styles are inaccessible from the Restyle component built from createText. This PR adds the following typography properties:

Fixes https://github.com/Shopify/restyle/pull/158 Fixes https://github.com/Shopify/restyle/pull/65

Reviewers’ hat-rack :tophat:

Screenshots or videos (if needed)

A video showcasing a few of the added properties:

https://user-images.githubusercontent.com/43865546/227000982-a4bc72fe-b78b-4bf8-831b-ac159d8f0256.mov

Checklist

fortmarek commented 1 year ago

We should also update the docs with the added props

mattfrances commented 1 year ago

Can we test the functionality similar as we did for gap props here by creating a new file called createText.test.tsx? I'd love for us to have some very basic coverage.

We should also update the docs with the added props

Done and done! ✅