Shopify / restyle

A type-enforced system for building UI components in React Native with TypeScript.
https://shopify.github.io/restyle/
MIT License
2.86k stars 128 forks source link

Add textVariants to docs #253

Closed sebastianekstrom closed 1 year ago

sebastianekstrom commented 1 year ago

Description

Screenshot 2021-12-02 at 13 31 39

When going through the docs one of the first thing you need to do is to define your theme (https://shopify.github.io/restyle/fundamentals/defining-your-theme). The example in this section however doesn't include the textVariants property.

This is not an immediate issue, but as soon as you start using the <Text /> component the app will crash because it requires this property. This can cause a bit of frustration and confusion.

Reviewers’ hat-rack :tophat:

To see the new documentation, follow these steps:

  1. Check out this branch locally
  2. cd documentation && yarn && yarn start
  3. Go to http://localhost:3000/restyle/fundamentals/defining-your-theme

You'll now see the new updated documentation

Screenshots or videos (if needed)

Before After
Screenshot 2023-04-05 at 15 30 53 Screenshot 2023-04-05 at 15 30 36

Checklist