search

Shopify / restyle

A type-enforced system for building UI components in React Native with TypeScript.
https://shopify.github.io/restyle/
MIT License
2.86k stars 128 forks source link

React Native 0.72 support #274

Closed edualm closed 4 months ago

edualm commented 10 months ago

Current behavior

It seems to me that Restyle does not properly support React Native 0.72.x. Attempting to upgrade a project to it resulted in a lot of TypeScript errors related to Restyle (which I can not make any sense of), while that upgrading to 0.71.x only resulted in a few errors.

Expected behavior

No TypeScript errors to occur.

To Reproduce

Try to use Restyle with React Native 0.72.x. I can create a demo project if needed.

Platform:

Environment

2.4.2, but I was using 2.1.0 before which also yields errors (but that would be expected in my opinion).

gvarandas commented 4 months ago

@edualm we use @shopify/restyle with React Native 0.72 and 0.73 internally without any TS issues. Could you please add either a small reproduction or at least list the errors you're seeing?

edualm commented 4 months ago

Hey @gvarandas,

I was able to upgrade our app to 0.73 and keep using restyle.

I had to re-look at our implementation and change some typings, but things seem to be working.

Thanks!