Upgrade React Native to 0.72

migueldaipre commented 9 months ago

Description

Possible fixes (issue #274)

This PR upgrades the React Native version to the latest 0.72. It also fixes all typescript, eslint, and testing errors related to the upgrade.

Reviewers’ hat-rack :tophat:

run the fixtures app and everything should work as expected

Video

https://github.com/Shopify/restyle/assets/21174859/0e9bd791-7069-4855-8a77-b4d20501713f

Checklist

[ ] I have added a changelog entry following the Keep a Changelog guidelines.

gvarandas commented 4 months ago

@migueldaipre could you resolve the conflicts and sign the CLA so we can get this in? 🙏

migueldaipre commented 4 months ago

I have signed the CLA!

migueldaipre commented 4 months ago

Done @gvarandas

migueldaipre commented 4 months ago

How should I change the changelog?

gvarandas commented 3 months ago

So, I was just testing your PR and it seems like we're missing a few pieces to make sure things work 100% as we'd expect:

The fixture app is set up using an old version of react-native-test-app, so we should probably update it (^3.4.3 seems like the latest)
- With that change some of the app's setup is also changed (Gradle files, react-native-config.json, etc), so we might need to revamp it as well
Running pod install relies on having a global version of cocoapods installed, which isn't great, so we should probably add a Gemfile to the fixture folder as well that installs it.

I've applied the changes to this branch (fixture_72), if you want to take a look and test it. Might be easy enough to add it to your PR so we can get it merged sooner than later 🙇

migueldaipre commented 3 months ago

Hey @gvarandas, I took a look and it worked perfectly for me.

gvarandas commented 3 months ago

@migueldaipre do you mind adding that commit to your PR then, so we can get it in?

migueldaipre commented 3 months ago

@gvarandas Done 🎉

Shopify / restyle