search

Shopify / retext-shopify

Warn about Shopify style guide violations with Retext.
Other
20 stars 18 forks source link

Add dashes #18

Closed nwtn closed 8 years ago

nwtn commented 8 years ago

@jeremyhansonfinger I had to add a million tests to figure out what was wrong; I figure it doesn’t hurt to keep them in.

Issue in this repo was that we were’t calling search properly — you can’t actually pass in false, true because there’s only one argument -- options. If options is a boolean it sets allowApostrophes. We need it to be an object where we explicitly set allowApostrophes and allowDashes.

jeremyhansonfinger commented 8 years ago

Waiting to resolve merge conflicts/merge until https://github.com/wooorm/nlcst-search/pull/3 and https://github.com/wooorm/nlcst-normalize/pull/1 have been merged

jeremyhansonfinger commented 8 years ago

Titus has merged and released nlcst-normalize (2.0.0!) and nlcst-search (1.2.0).

jeremyhansonfinger commented 8 years ago

👍

Manually merged from command line because of merge conflict.

Closed by 9d71de33519d8ecea9161540f4be7d1b96a253d7