search

Shopify / rubocop-sorbet

A collection of RuboCop rules for Sorbet
MIT License
178 stars 26 forks source link

Fix registry deprecation notice #240

Closed andyw8 closed 2 months ago

andyw8 commented 2 months ago

Closes https://github.com/Shopify/rubocop-sorbet/issues/238

andyw8 commented 2 months ago

Started work on moving to RuboCop::Cop::Base.

koic commented 2 months ago

@andyw8 If you don't mind, I can open a PR to migrate to the V1 API for RuboCop::Cop::Base. In that case, it would be sufficient in this PR to just change Cop.registry to Registry.global. What do you think?

andyw8 commented 2 months ago

@koic we started on that in 935bdf71f6fa5da3fad0dd2b79d14150020e66e3 but if you'd like to take over, please go ahead.

koic commented 2 months ago

@andyw8 Yeah, I've opened #241 to solve it. Since Cop.registry warning is being addressed in this PR, it is not handled in that PR.

andyw8 commented 2 months ago

Thanks. I've reset this branch to contain only the Cop.registry change.