search

Shopify / rubocop-sorbet

A collection of RuboCop rules for Sorbet
MIT License
181 stars 27 forks source link

Make custom cop inherit `RuboCop::Cop::Base` #241

Closed koic closed 3 months ago

koic commented 3 months ago

Follow up https://github.com/Shopify/rubocop-sorbet/pull/240#issuecomment-2223587240.

The legacy Cop::Cop API is deprecated and this PR use new Cop::Base API instead.

maintain any RuboCop extensions, as the legacy API will be removed in RuboCop 2.0.

https://metaredux.com/posts/2020/10/21/rubocop-1-0.html

andyw8 commented 3 months ago

cc @sambostock

andyw8 commented 3 months ago

(I will fix that failure then merge)

koic commented 3 months ago

@andyw8 I've rebased it with the latest main branch to pass CI.