Shopify / ruby-lsp-rails

A Ruby LSP addon for Rails
https://shopify.github.io/ruby-lsp-rails/
MIT License
518 stars 21 forks source link

Only display code lens when the test framework is rails #318

Closed st0012 closed 3 months ago

st0012 commented 3 months ago

Currently, ruby-lsp-rails also sends code lens even when the test library is not rails. This creates problem when the user has both ruby-lsp-rspec and ruby-lsp-rails installed and the test framework is rspec, as the duplicated code lens will be cause none of them to display.

I also removed obsolete test setups that create/remove message queues manually. They're not used after the with_server is adopted.

vinistock commented 3 months ago

We still need to improve the test framework detection logic in the Ruby LSP to fully fix the Ruby LSP RSpec issue though, right?

st0012 commented 3 months ago

@vinistock Yeah that's true. I'm working on it now.