Reload the runner if structure.sql changes

Shopify / ruby-lsp-rails

A Ruby LSP addon for Rails

https://shopify.github.io/ruby-lsp-rails/

MIT License

518 stars 21 forks source link

Reload the runner if structure.sql changes #341

Closed Earlopain closed 2 months ago

Earlopain commented 2 months ago

Closes #326

There already exists a test that modifications to structure.sql ends up reloading but without proper integration tests this behaviour isn't really testable.

To confirm this works:

Get a rails app with structure.sql
Make a change and save, look at the log output to validate it reloaded.
Make some changes to a *.rb file to confirm that this new listener doesn't overwrite the main one.

andyw8 commented 2 months ago

Thank you! I've tested and it's working well.

andyw8 commented 2 months ago

~Let's also update workspace_did_change_watched_files to remove structure.sql? We can add a comment that it's only for Ruby files.~ Ignore, misunderstood.

vinistock commented 2 months ago

Just needs a rebase, but LGTM.