search

Shopify / ruby-lsp-rails

A Ruby LSP addon for Rails
https://shopify.github.io/ruby-lsp-rails/
MIT License
518 stars 21 forks source link

Update tests for `ruby-lsp` changes #350

Closed Earlopain closed 2 months ago

Earlopain commented 2 months ago

Since https://github.com/Shopify/ruby-lsp/pull/1896 the testing framework for rails is dependant on the presence on bin/rails.

For https://github.com/Shopify/ruby-lsp-rails/pull/341 I need to bump the minimum required ruby-lsp but tests are failing due to the above PR, so I fix them here in a separate PR.

Earlopain commented 2 months ago

Note: There are some green checks even though I'm pretty sure they should fail. I think tests doesn't run on windows right now because of how it is invoked in the workflow. It probably chokes on the &&.

https://github.com/Shopify/ruby-lsp-rails/actions/runs/8821159752

andyw8 commented 2 months ago

Note: There are some green checks even though I'm pretty sure they should fail. I think tests doesn't run on windows right now because of how it is invoked in the workflow. It probably chokes on the &&.

https://github.com/Shopify/ruby-lsp-rails/actions/runs/8821159752

Thanks, logged as https://github.com/Shopify/ruby-lsp-rails/issues/351