search

Shopify / ruby-lsp-rails

A Ruby LSP addon for Rails
https://shopify.github.io/ruby-lsp-rails/
MIT License
518 stars 21 forks source link

Fix CI setup for Windows #352

Closed andyw8 closed 2 months ago

andyw8 commented 2 months ago

Closes https://github.com/Shopify/ruby-lsp-rails/issues/351 but we still need to address https://github.com/Shopify/ruby-lsp-rails/issues/348.

andyw8 commented 2 months ago

Still seeing failures with the higher timeout... perhaps we are failing to shutdown the server properly on Windows, and it's using a ton of memory, leading to the slowness.

andyw8 commented 2 months ago

@vinistock @st0012 this is ready for another look.

I propose that we get CI running for Windows again, then work on https://github.com/Shopify/ruby-lsp-rails/issues/348 separately.

andyw8 commented 2 months ago

Another possible approach is to prefix the binstub calls with ruby: https://github.com/Shopify/ruby-lsp-rails/commit/bf9324b516dc422d180ad4d20b68dbe92c604337

I've verified this works in CI. It does kinda make sense that the binstub on its own wouldn't work on windows since the #!/usr/bin/env ruby is likely ignored... so does this mean there's no real way to write a cross-platform binstub?

andyw8 commented 2 months ago

@vinistock all passing now.

andyw8 commented 2 months ago

I should've rebased before merging, as there are some failures in main now for Windows. Looking into.