Shopify / ruby-lsp-rails

A Ruby LSP add-on for Rails
https://shopify.github.io/ruby-lsp/rails-add-on
MIT License
581 stars 27 forks source link

Avoid loading Rails or ActiveSupport in tests #510

Open andyw8 opened 3 weeks ago

andyw8 commented 3 weeks ago

To prevent issues such as https://github.com/Shopify/ruby-lsp-rails/pull/509 we can switch to using Minitest::Test instead of ActiveSupport::TestCase for the test files.

I have temporarily added the test_declarative gem to avoid editing all the test declarations, but if we decide to go ahead then I can do that.

We have one test file (server_test.rb) that does need to load Rails so I have split that out.

~There is currently one failing test that I need to look into.~ fixed

andyw8 commented 3 weeks ago

@vinistock any thoughts?