Group incomplete and empty message into MessageError

Shopify / ruby-lsp-rails

A Ruby LSP add-on for Rails

https://shopify.github.io/ruby-lsp/rails-add-on

MIT License

581 stars 27 forks source link

Group incomplete and empty message into MessageError #515

Closed vinistock closed 3 weeks ago

vinistock commented 3 weeks ago

We're sometimes hitting EmptyMessageError in certain cases after the changes in #498. We only rescue IncompleteMessageError, which then makes it look like the add-on is crashing.

Let's group the two errors under a common ancestor, so that we can rescue all types of message errors where needed.

vinistock commented 3 weeks ago

#515 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vinistock and the rest of your teammates on Graphite

vinistock commented 3 weeks ago

Merge activity

Nov 6, 10:50 AM EST: A user merged this pull request with Graphite.