search

Shopify / ruby-lsp

An opinionated language server for Ruby
https://shopify.github.io/ruby-lsp/
MIT License
1.35k stars 121 forks source link

Improve client integration tests #2033

Closed vinistock closed 2 days ago

vinistock commented 3 weeks ago

Motivation

While working on #2017, I realized that our client integration test was not activating Ruby (it just used the one available on CI), which was actually masking some issues.

This PR improves our tests and fixes the related issues to make tests pass.

Implementation

The PR is split by commit:

  1. Environment variables are case sensitive and Windows uses the name Path instead of PATH, which was causing us to miss the general environment on the RubyInstaller integration
  2. This commit includes the improvements to the test, which now displays more information about failures and ensures the right Ruby is activated to run integrations

Automated Tests

Added tests.