github-actions[bot]
commented
1 year ago Benchmark results in seconds (slowest at top)
textDocument/formatting average: 0.14501 std_dev: 0.037029
textDocument/diagnostic average: 0.05212 std_dev: 0.003625
textDocument/selectionRange average: 0.004933 std_dev: 0.000883
textDocument/foldingRange average: 0.002045 std_dev: 0.000333
textDocument/documentHighlight average: 0.001859 std_dev: 0.000327
textDocument/semanticTokens/full average: 0.001025 std_dev: 0.000308
textDocument/semanticTokens/range average: 0.000765 std_dev: 0.000144
textDocument/hover average: 0.00072 std_dev: 0.000269
textDocument/documentLink average: 0.000653 std_dev: 0.000151
textDocument/inlayHint average: 0.000457 std_dev: 0.000121
textDocument/documentSymbol average: 0.000318 std_dev: 0.000101
textDocument/onTypeFormatting average: 0.000135 std_dev: 0.000105
textDocument/codeAction average: 4.1e-05 std_dev: 8.8e-05
================================================================================
Comparison with main branch:
textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
textDocument/documentSymbol unchanged
textDocument/foldingRange unchanged
textDocument/formatting unchanged
textDocument/diagnostic unchanged
textDocument/documentLink unchanged
textDocument/inlayHint unchanged
textDocument/selectionRange unchanged
textDocument/documentHighlight unchanged
textDocument/hover unchanged
textDocument/codeAction unchanged
textDocument/onTypeFormatting unchanged
andyw8
vinistock
Motivation
When tests are defined as normal methods using the
def test_somethingsyntax, they are treated as document symbols, as any other method would be. But when using thetest "some string"syntax provided by ActiveSupport, they are not detected. By adding support for those, VS Code can show them in the Outline View, and list them you press@in the command palette.This uses some of the earlier exploratory work by @DeeChau in https://github.com/Shopify/ruby-lsp/pull/490
Implementation
Currently this does not support other syntax such as RSpec, but I hope to add that in future.
Automated Tests
I've added a new fixture and expectation.
Manual Tests
Choose a large project which uses ActiveSupport tests, e.g. a Rails project. Ensure that each tests is listed in the Outline view.