Closed mikkoh closed 2 years ago
Currently the modelviewerUrl is being prepared in captureScreenshot. I'd like to move this logic into prepareAppOptions.
modelviewerUrl
captureScreenshot
prepareAppOptions
To me this makes sense since the model_viewer_version passed via argv is used to determine the modelviewerUrl.
model_viewer_version
argv
In the next PR I'd like to make it so you can pass a local path to a model-viewer.js file which can then be used to prepare screenshots.
model-viewer.js
Currently the
modelviewerUrlis being prepared incaptureScreenshot. I'd like to move this logic intoprepareAppOptions.To me this makes sense since the
model_viewer_versionpassed viaargvis used to determine themodelviewerUrl.In the next PR I'd like to make it so you can pass a local path to a
model-viewer.jsfile which can then be used to prepare screenshots.