search

Shopify / seafoam

A tool for working with compiler graphs dumped by the GraalVM compiler
MIT License
126 stars 22 forks source link

Refactor commands #17

Closed chrisseaton closed 3 years ago

chrisseaton commented 3 years ago

So they're easier to test, such as in #16.

LillianZ commented 3 years ago

It works for me and looks reasonable, though since I didn't update my crabstone version I'm still getting the depreciation warning - even on the 3 bgv file commands.

That makes me concerned that seafoam/bgv2XXX could fail to work if someone doesn't have crabstone installed, which seems bad.

chrisseaton commented 3 years ago

Ah yes I'll look into what happens when Crabstone isn't installed, thanks very much for the idea! You'd need to bundle instally again (I think...) to get the new version.