Shopify / seafoam

A tool for working with compiler graphs dumped by the GraalVM compiler
MIT License
126 stars 22 forks source link

Make node source output stack trace clickable #43

Open wildmaples opened 2 years ago

wildmaples commented 2 years ago

Usually when we copy and paste something into Analyze > Stack Thread or Tread Dump in IntelliJ IDEA, the stacktrace is clickable to the location of the code.

Currently when you paste seafoam source output it looks like this:

Screen Shot 2021-09-21 at 3 50 23 PM

But in order to be clickable it should look something like this (right panel):

image Image from JetBrain documentation on: Analyzing External Stack Traces

It seems to contain the full file name and line number.

I know that we currently don't have access to the specific line number, but would it still work with just the full file name?

chrisseaton commented 2 years ago

We have the BCI (byte code index) - maybe it's easier than we think to map those to a file line? The javap command may be able to help us do it.