search

Shopify / seafoam

A tool for working with compiler graphs dumped by the GraalVM compiler
MIT License
126 stars 22 forks source link

Update Ruby version to support 2.3.7 #51

Closed chrisseaton closed 2 years ago

chrisseaton commented 2 years ago

For @eregon

chrisseaton commented 2 years ago

@eregon do you know how I can fix these problems supporting such an old version of Ruby?

eregon commented 2 years ago

I think the issue is the Gemfile.lock is checked in the repo, and parallel 1.21.0 needs Ruby >= 2.5, so you'd need to reresolve the Gemfile to install properly. One way would be to not check in Gemfile.lock in the repo (common for gems, because then CI runs represent what users get when they install seafoam, which automatically uses the latest dependencies). But the dependencies here are actually test dependencies, so that's not so useful. Could explicitly rm Gemfile.lock before using setup-ruby as one way.

Supporting 2.3 might not be worth the effort, I'll keep you updated.

eregon commented 2 years ago

We should be able to build a more recent Ruby in macOS, so this can be closed.