Shopify / seafoam

A tool for working with compiler graphs dumped by the GraalVM compiler
MIT License
126 stars 22 forks source link

simplify_alloc doesn't support nested clases #67

Closed chrisseaton closed 5 months ago

chrisseaton commented 1 year ago
(m = /^(\w+(?:\[\])?)\[([0-9,]+)\]$/.match(value)) || raise(value)

Doesn't match for example Foo$Bar.

Should it just be:

(m = /^([\w\$]+(?:\[\])?)\[([0-9,]+)\]$/.match(value)) || raise(value)

Also raising with a better error message would be better.

@eregon

nirvdrum commented 5 months ago

Fixed by #73.