search

Shopify / seafoam

A tool for working with compiler graphs dumped by the GraalVM compiler
MIT License
126 stars 22 forks source link

Fix undefined `prepare_json` for JSONWriter #80

Closed jmesyou closed 5 months ago

jmesyou commented 1 year ago

Fixes #79

jmesyou commented 1 year ago

I have signed the CLA!

nirvdrum commented 5 months ago

Hi, @jmesyou. I'm sorry that I missed the notification about this PR and the associated issue. I really appreciate you opening this PR, but the changes would violate the style guide and I wanted to add a new test. The core problem was the class method wasn't being called correctly. I've added a new test to verify it all works in #82.

I'm planning to create a new release sometime over the next week. The next GraalVM is scheduled for release on March 19 and it changes the package names for many nodes so we need to update this project for that anyway.