Pending CI isn't update

Shopify / shipit-engine

Deployment coordination

https://shopify.engineering/introducing-shipit

MIT License

1.41k stars 145 forks source link

Pending CI isn't update #1123

Open David-Vaknin-Vcita opened 3 years ago

David-Vaknin-Vcita commented 3 years ago

HI, I'm facing an issue with the dashboard status, and id like to get some help.

Issue:

When shipit identifies commit, it possible to see it under Commits & Deploys tab with a status of "Pending CI." Then, When the CI process is done, and GitHub displays the CI statuses (which I marked as required ) with pass status and even shipit allow me to send the "/shipit" command, The dashboard keeps showing the pending CI icon and disallow to hit the deploy button.

Screen Shot 2020-11-25 at 13 19 55

I really appreciate any help you can provide.

casperisfine commented 3 years ago

This likely means shipit missed the event. It could have several causes:

If it happens all the time, it could simply be that you webhooks are misconfigured.
If it's a one time occurence, it might just be a single failed webhook, clicking Refresh statuses & commits should fix it.

If the error persist after clicking "Refresh statuses & commits", then there's a bigger problem that our report doesn't allow to identify.

David-Vaknin-Vcita commented 3 years ago

Thanks for your quick response.

From your option, it seems like the case is: "If it happens all the time, it could simply be that your webhooks are misconfigured."

Can you direct me where to double-check my configuration?

Thanks!

casperisfine commented 3 years ago

It's documented here: https://github.com/Shopify/shipit-engine/blob/master/docs/setup.md#creating-the-github-app

You want to make sure your GitHub App is configured to send Status events (and the other listed ones while you are at it).

Then once you are there you can also look at the webhooks logs on the GitHub side and see if they are acknowledged with a 200. If not something else might be wrong in your config.