Shopify / shipit-engine

Deployment coordination
https://shopify.engineering/introducing-shipit
MIT License
1.42k stars 144 forks source link

Clarify deploy start and finish datetime #1218

Closed maximevaillancourt closed 10 months ago

maximevaillancourt commented 3 years ago

This commit clarifies when a deploy started:

Without this commit, it's unclear whether the "20 minutes" part is when the deploy started or when it finished.

With this commit, it's much clearer.

casperisfine commented 3 years ago

Looks good to me, could you include a screenshot though? I'm just worried the extra size might cause wrapping or things like that.

maximevaillancourt commented 10 months ago

Closing: doesn't seem necessary (hey Jean, it's been a while) 😄

casperisfine commented 10 months ago

👋