search

Shopify / shipit-engine

Deployment coordination
https://shopify.engineering/introducing-shipit
MIT License
1.42k stars 144 forks source link

"Environment is invalid" warning doesn't disappear #1221

Closed erik-shopify closed 3 years ago

erik-shopify commented 3 years ago

If a user attempts to create a new stack using an invalid environment name, they are displayed an "Environment is invalid" warning that doesn't disappear after the name becomes formatted correctly, and the warning continues to persist on all subsequent pages after the stack is created until the site is refreshed.

I think the warning should disappear by the time the stack is successfully created as the warning is no longer relevant past that point.

Steps to reproduce:

  1. Attempt to create a new stack with an invalid environment name (for example: eqr/production).
  2. Change the environment name to an accepted format (for example: production) and finish creating the stack.
  3. The warning should still display on the following pages visited.
warning on create warning on another page

Probably another ticket, but I wonder if we should consider a more descriptive error that specifies the accepted characters for environment_name.

erik-shopify commented 3 years ago

After a quick test this seems to be resolved, I'm going to close the issue for now. Thanks!