Shopify / shipit-engine

Deployment coordination
https://shopify.engineering/introducing-shipit
MIT License
1.42k stars 144 forks source link

Add --quiet switches to checkouts #1278

Closed atesgoral closed 2 years ago

atesgoral commented 2 years ago

Follow-up to #1219 and #1225. Missed a spot.

Output is garbled due to progress feedback of checkout:

image

Tophatted locally:

git -c advice.detachedHead=false checkout --quiet 05f5b2e2b72a80491d8ebe3e91a350a7ae09dc5e
ajshepley commented 2 years ago

This is something we might want to look at making customizable per-stack at some point (perhaps allowing stacks to override the whole git command itself might make sense?). But in any case, quiet by default makes sense.

atesgoral commented 2 years ago

@ajshepley I've been thinking about the same. Other consumers of shipit-engine might still make good use progress output. Might make sense to revise all the silencing we've added so far and add an option to toggle verbosity / progress.

benlangfeld commented 2 months ago

@mfilipe has an interest in contributing making these quiet flags configurable. In our use case we're currently running on a fork which removes them in order to avoid timing out log collection on long git clone operations.