Shopify / shipit-engine

Deployment coordination
https://shopify.engineering/introducing-shipit
MIT License
1.42k stars 146 forks source link

Update `ContinuousDeliveryJob` to account for concurrent tasks #1309

Closed ruionweb closed 1 year ago

ruionweb commented 1 year ago

When you force deploy via the api controller, it sets allow_concurrency to true. So when the pipeline is unlocked and ContinuousDeliveryJob runs, it only checks for non-concurrent tasks with the current function. This means that another deployment of the same commit can be triggered by the ContinuousDeliveryJob simultaneously.

This updates ContinuousDeliveryJob so that it doesn't trigger a deploy if there is a concurrent task running.