Shopify / shipit-engine

Deployment coordination
https://shopify.engineering/introducing-shipit
MIT License
1.41k stars 144 forks source link

Deployment status not updating in GitHub #1311

Closed pcothenet closed 3 months ago

pcothenet commented 1 year ago

Hi team shipit! Thanks a lot for your great work on this tool!

Since last week, our shipit instance isn't updating the status of the deployment in GitHub anymore.

The deploys are still working as expected:

Screenshot 2023-07-03 at 9 57 05 AM

Yet, the Deployment status stays in "Pending" in GitHub:

Screenshot 2023-07-03 at 9 17 12 AM

In logs, we can see the following error, with a timing corresponding to the end of a deploy.

Couldn't find template for digesting: statuses/status

Things we have tried so far that haven't helped:

Another thing of note is that the issue started happening at the same time as the big GitHub outages of last week, and also correlates with some instability of our shipit hosting.

Any ideas what might be causing this and how to fix it?

benlangfeld commented 1 year ago

commit_deployment_statuses.github_id needs to be a bigint rather than an int. Github got too big.

pcothenet commented 1 year ago

@benlangfeld I added a migration to our instance and that did the trick, thanks for the pointer. I'll try to open a PR to add to the repo.

benlangfeld commented 1 year ago

Credit goes to @ryanmrodriguez for tracking this one down.

solojavier commented 3 months ago

@pcothenet @benlangfeld Since the PR has been merge I believe this ticket can be marked as closed now.