search

Shopify / shipit-engine

Deployment coordination
https://shopify.engineering/introducing-shipit
MIT License
1.41k stars 144 forks source link

Paginate check run refresh #1325

Closed sjagoe closed 3 months ago

sjagoe commented 7 months ago

Paginate check runs when fetching from GitHub to handle cases where more than 30 checks exist. #1323

sjagoe commented 7 months ago

I'm working on the CLA, but it's going to take a bit of time. I'm waiting for somebody with signing capacity to either sign the corporate CLA, or release this to me and I can do it as a personal contribution.

casperisfine commented 7 months ago

I'm working on the CLA, but it's going to take a bit of time.

Yeah, It's a PITA, sorry about that. Let me know once it's done.

sjagoe commented 4 months ago

Apologies for the extreme delay here. I have signed the CLA.

casperisfine commented 4 months ago

Sorry I was in vacation. Unfortunately, CI now fail, and that seems legit.

sjagoe commented 4 months ago

I'll make some time to look into this soon

solojavier commented 3 months ago

@sjagoe @casperisfine I updated the tests to work with these changes.

I created a PR from my fork to sjagoe fork here: https://github.com/sjagoe/shipit-engine/pull/1/files

Not sure if this is the best way to do it, so happy to update as needed.

sjagoe commented 3 months ago

Thanks for taking care of the tests @solojavier and sorry it came to you having to do that work.

solojavier commented 3 months ago

Thanks merging it. I'm happy to help :)