Closed kartiki975 closed 7 months ago
Just to check - were we able to test these changes in our Shipit instance?
@kwboyd-shopify I didn't do a tophat but the CI checks were passing when I temporarily integrated this branch's changes here: https://github.com/Shopify/shipit/pull/2589/commits/bd719ee152153205b97bdd1d47279ef7a9a7c124
Gotcha! I'll pull these changes and do a quick test today before approving.
With a recent tophat on internal Shipit with these changes, a 500 error is preventing batched changes to start deploying. No longer looking for reviews until I fix that issue 😞
Thanks for tophatting as well, @erik-shopify! In regards to indefinite soaking, I am not seeing that on my end... that may be flakiness 🤔 let me know if you see anything unusual on any of your recent tophat attempts.
In attempts to use the recent shipit-engine release, I noticed the following exception being thrown in CI checks:
This PR seeks to avoid this exception by migrating to credentials as instructed here: https://github.com/Shopify/ejson-rails?tab=readme-ov-file#migrating-to-credentials.
There were 3 other deprecation warnings that were being reported during unit tests. Those have been addressed as well.