search

Shopify / shipit-engine

Deployment coordination
https://shopify.engineering/introducing-shipit
MIT License
1.41k stars 144 forks source link

Update `build_deploy` with `allow_concurrency` keyword argument #1334

Closed kartiki975 closed 5 months ago

kartiki975 commented 5 months ago

1 of 2 PRs (2nd PR will be in an Internal Shopify service)

There is an internal Shopify ticket that hopes to separate concurrent deploys from force=true for the deploy API. To avoid overriding the whole build_deploy method in our internal service, I have updated the method signature to accept allow_concurrency field but default it to force to keep the existing implementation.

Changelog and README.md have been updated in case other users would also like to more control of the concurrency of deployments; note, that this differs from rollback whose concurrency is still limited to force.