Fix Rubocop violations - Githubissues

Shopify / shipit-engine

Deployment coordination

https://shopify.engineering/introducing-shipit

MIT License

1.41k stars 144 forks source link

Fix Rubocop violations #1340

Closed jenshenny closed 5 months ago

jenshenny commented 5 months ago

From https://github.com/Shopify/shipit-engine/pull/1339, RuboCop was bumped to 1.61 to get these changes.

This PR addresses the new cops. I added Style/OpenStructUse, Style/ClassMethodsDefinitions and Lint/MissingCopEnableDirective to the RuboCop exclusions.

casperisfine commented 5 months ago

Thanks for the effort but I don't want these changes. shipit-engine predates the Shopify style guide and I don't want to make this much changes for a repo that is mostly stable.