Closed 5n00p4eg closed 7 months ago
Thank you so much for contributing, we appreciate it! I think this is the right idea, but I have some thoughts:
throwFailedRequest
. We could make response
accept Response | undefined
and then throw first thing if no response is present. That way all of these cases would behave the same way.queueError
instead of queueMockResponse
in the test file to trigger this scenario@paulomarg Take a look, please
WHY are these changes introduced?
In some cases, fetch response is not available for error handling, so type error appears:
Related issues: Shopify/shopify-app-js#764
WHAT is this pull request doing?
In case of
response
object is not avaliabeGraphqlQueryError
is raised directly with outer response data.Type of change
Checklist
yarn changeset
to create a draft changelog entry (do NOT update theCHANGELOG.md
file manually)