search

Shopify / shopify-api-php

MIT License
371 stars 171 forks source link

Exception stacktrace goes missing when the processing of a webhook catches it #343

Closed linaori closed 1 month ago

linaori commented 3 months ago

When an exception occurs in a handler the exception message is passed to the result object, but the stacktrace (and any previous exceptions) go missing) meaning that if I try to log it I can't find the origin of the error and I'm left with Failed to process 'orders/paid' webhook: Trying to access array offset on value of type null

https://github.com/Shopify/shopify-api-php/blob/main/src/Webhooks/Registry.php#L158-L163

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

github-actions[bot] commented 1 month ago

We are closing this issue because it has been inactive for a few months. This probably means that it is not reproducible or it has been fixed in a newer version. If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

linaori commented 1 month ago

Well that's 1 way to get rid of issues.