search

Shopify / shopify-api-ruby

ShopifyAPI is a lightweight gem for accessing the Shopify admin REST and GraphQL web services.
MIT License
1.06k stars 473 forks source link

REST API Shop resource definitions TypeError #1145

Closed LovroM closed 1 year ago

LovroM commented 1 year ago

Issue summary

When trying to access 'taxes_included' and 'tax_shipping' fields on the shop resource it fails because of the wrong sorbet type definition. The Shopify documentation states that both fields should be booleans but in shop resource are defined as strings. https://shopify.dev/docs/api/admin-rest/2023-04/resources/shop

Expected behavior

>shopify_shop.taxes_included
>true

>shopify_shop.tax_shipping
>true

Actual behavior

> shopify_shop.taxes_included
> TypeError (Return value: Expected type T.nilable(String), got type TrueClass)

> shopify_shop.tax_shipping
> TypeError (Return value: Expected type T.nilable(String), got type TrueClass)
nelsonwittwer commented 1 year ago

Thanks for providing this report! We've added to our list of things to fix in our schema that generates these rest resources. It'll be merged in the next few days and out with our next release.

lovro-mekis-latori commented 1 year ago

Hi @nelsonwittwer , the new (13.0.0) release is out and this was not fixed, when can we expect this to be resolved?