eject session storage

[nelsonwittwer]

Description

Removes session storage from API library. This feature was deprecated in https://github.com/Shopify/shopify-api-ruby/pull/1055. It was decided that session persistance is best handled by shopify_app gem.

As part of rejecting session storage, we needed to refactor GraphQLProxy#proxy_query to pass in a session instead of reading it from cookie / header.

How has this been tested?

In addition to the automated testing, this branch was pointed at with a generated app from the CLI. Was able to install the app on a store, and uninstall the app a store. Was able to make API calls.

Checklist:

• [ ] My commit message follow the pattern described in here
• [ ] I have performed a self-review of my own code.
• [ ] I have added tests that prove my fix is effective or that my feature works.
• [ ] I have updated the project documentation.
• [ ] I have added a changelog line.

[jaredbeck]

[ ShopifyAPI | WARN ] The use of SessionStorage in the API library has been deprecated. The ShopifyAPI will no longer have responsibility for session persistence. Upgrading to shopify_app 21.3 will allow you to remove session_storage from the API library Context configuration.

Please confirm that there are exactly two upgrade steps:

1. upgrade shopify_app to 21.3
2. remove session_storage from ShopifyAPI::Context.setup

Are any other changes necessary? Thanks.

[mattsrobot]

@jaredbeck did you find any solution? I'm lost.

[jaredbeck]

@jaredbeck did you find any solution? I'm lost.

I asked my Shopify Support contact, and received the following response:

From what our engineers have explained, removing session_storage from your API context block in the initializer, will [be sufficient].