Shopify / shopify-api-ruby

ShopifyAPI is a lightweight gem for accessing the Shopify admin REST and GraphQL web services.
MIT License
1.06k stars 473 forks source link

Remove `ruby-lsp` from dependencies #1231

Closed vinistock closed 1 year ago

vinistock commented 1 year ago

Description

When I was working on #1226, I noticed that this gem still has the ruby-lsp as a development dependency.

We made changes so that the server can auto-update itself and it's no longer recommended to leave it in the gemspec or Gemfile.

This PR just removes the ruby-lsp from the gemspec so that people working on it get auto-updates. I also upgraded the parser gem because there's a bug that prevents the LSP from starting in older versions.

These are only development changes.

How has this been tested?

Opened VS Code on the project, verified that I got the latest Ruby LSP server version running.

Checklist:

vinistock commented 1 year ago

Tagging @mllemango since I no longer have permissions to merge PRs.

andyw8 commented 1 year ago

@zzooeeyy are you able to merge this please?