search

Shopify / shopify-api-ruby

ShopifyAPI is a lightweight gem for accessing the Shopify admin REST and GraphQL web services.
MIT License
1.06k stars 471 forks source link

Webhooks processing for mandatory webhooks is broken #1248

Closed nelsonwittwer closed 11 months ago

nelsonwittwer commented 11 months ago 
          I think this breaks webhooks processing for mandatory webhooks.

https://github.com/Shopify/shopify-api-ruby/blob/82e4caf30c21a67a68384b5abcc897884dbc5065/lib/shopify_api/webhooks/registry.rb#L179-L183

The @registry[request.topic] will be nil for mandatory webhooks because they were skipped in https://github.com/Shopify/shopify-api-ruby/blob/82e4caf30c21a67a68384b5abcc897884dbc5065/lib/shopify_api/webhooks/registry.rb#L25-L27

Originally posted by @mironov in https://github.com/Shopify/shopify-api-ruby/issues/1237#issuecomment-1811121089

yann120 commented 11 months ago

Hi @nelsonwittwer , do you think it could be the cause this error on my app since yesterday : ShopifyAPI::Errors::NoWebhookHandler No webhook handler found for topic: shop/redact. I didn't change anything and I think that this webhook was working before...