Shopify / shopify-api-ruby

ShopifyAPI is a lightweight gem for accessing the Shopify admin REST and GraphQL web services.
MIT License
1.05k stars 468 forks source link

Adding indifferent access #1308

Closed elizasorber closed 1 month ago

elizasorber commented 5 months ago

Tackling issue #1296 Added indifferent access to create_instances_from_response in the ShopifyAPI::Rest::Base class.

Description

Fixes #

Please, include a summary of what the PR is for:

How has this been tested?

Please, describe the tests that you ran to verify your changes.

Checklist:

sle-c commented 5 months ago

@elizasorber , could you sign the CLA https://cla.shopify.com/ and comment "I have signed the CLA!"?

elizasorber commented 5 months ago

I have signed the CLA!

elizasorber commented 4 months ago

@sle-c Hi! Do I need to write tests or a changelog entry to get this issue approved and merged?

sle-c commented 4 months ago

hey @elizasorber , yeah we need a changelog entry and also change the import from /all to more explicit imports

sle-c commented 4 months ago

there's a rubocop rule that we need to fix as well as rebase on the main branch :)