Add new SessionUtil method to retrieve current session Id from Shopify ID token - Githubissues

Shopify / shopify-api-ruby

ShopifyAPI is a lightweight gem for accessing the Shopify admin REST and GraphQL web services.

MIT License

1.05k stars 468 forks source link

Add new SessionUtil method to retrieve current session Id from Shopify ID token #1314

Closed zzooeeyy closed 4 months ago

zzooeeyy commented 4 months ago

Description

Partially fixes https://github.com/Shopify/develop-app-access/issues/289

Please, include a summary of what the PR is for:

What is the problem it is solving?
- current_session_id expects an "auth_header" that has format - Bearer id_token, extracted the logic to retrieve the current session ID from just id_token for supporting id token in URL param
- Added tests for SessionUtils that didn't exist before

Impact

Existing apps using current_session_id will not be affected, behaviour remained the same.

How has this been tested?

Unit tested and it still passes

Checklist:

[x] My commit message follow the pattern described in here
[x] I have performed a self-review of my own code.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have updated the project documentation.
[x] I have added a changelog line.