Fix type for Shop#google_apps_login_enabled - Githubissues

Shopify / shopify-api-ruby

ShopifyAPI is a lightweight gem for accessing the Shopify admin REST and GraphQL web services.

MIT License

1.06k stars 473 forks source link

Fix type for Shop#google_apps_login_enabled #1337

Closed kirillplatonov closed 2 months ago

kirillplatonov commented 2 months ago

Description

Fixes #1334

Fixes incorrect type of Shop#google_apps_login_enabled attribute in REST API.

How has this been tested?

This code can be used to reproduce the issue and test the fix:

shop = Shop.last
shopify_shop = shop.with_shopify_session do
  ShopifyAPI::Shop.all.first
end
shop_data = shopify_shop.to_hash
shop_data["google_apps_login_enabled"] = true
loaded_shop = shop.with_shopify_session do
  ShopifyAPI::Shop.new(from_hash: shop_data)
end
loaded_shop.google_apps_login_enabled

Checklist:

[x] My commit message follow the pattern described in here
[x] I have performed a self-review of my own code.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have updated the project documentation.
[x] I have added a changelog line.

kirillplatonov commented 2 months ago

cc @paulomarg