Shopify / shopify-app-bridge

https://shopify.dev/docs/api/app-bridge
85 stars 9 forks source link

NavigationMenu entries are clickable even when the menu is not shown. #150

Open james-theinsightlab opened 1 year ago

james-theinsightlab commented 1 year ago

Describe the bug

The menu entries for the NavigationMenu component are clickable even when they are not displayed within the Shopify POS app integration. To the end user the effect is you can click on certain parts of the page where nothing is present and it will navigate to another page.

To Reproduce

Steps to reproduce the behaviour:

  1. Follow the steps at https://shopify.dev/apps/getting-started/create to create a new app using the Shopify node template.
  2. Enable "embedding in Shopify POS" for this newly created app, (via the Shopify Partner dashboard.)
  3. Using an Android tablet or emulator, open the Shopify POS app and configure it to login to the development store.
  4. On the home screen click "Add tile" and add the created test app.
  5. Back on the home screen click the tile to launch the test app. Once the test app opens, click/tap in the area highlighted red in the screenshot. AppBridge Bug 1
  6. The app will change pages to the "Page name" page, even though you didn't select it in the menu.

Expected behaviour

The expected behaviour would be that nothing would happen, as there is nothing clickable/tap-able in that region of the screen. It appears that the NavigationMenu entries are still clickable even when the menu is not shown. You can see in the screenshot below that when the menu is made visible, (by clicking on the "App name" title,) you can see where the menu entries appear on screen. Thus clicking on the same area of the screen when the menu is not visible acts as if the menu was there. AppBridge Bug 2

Contextual information

Packages and versions

Platform

adearriba commented 1 year ago

Still a bug. I opened an issue right now for IOS too: https://github.com/Shopify/shopify-app-bridge/issues/165