Shopify / shopify-app-bridge

https://shopify.dev/docs/api/app-bridge
85 stars 9 forks source link

Please fix npmjs.com links and publish change logs #173

Closed pgib closed 6 months ago

pgib commented 1 year ago

Describe the feature you’d like

  1. The Repository (@shopify/app-bridge and @shopify/app-bridge-react) and Homepage (@shopify/app-bridge-react only) links in the published npm packages are broken. @shopify/app-bridge @shopify/app-bridge-react
  2. You don't publish any change log, so it's impossible to know fixes or surprises lie in store should we update!
image

Describe alternatives you've considered

I don't see any alternatives here.

Additional context

Please put yourself in the shoes of developers of your platform who do not work at Shopify.

nicklozon commented 1 year ago

The repository link actually exists, or at least it did at one point, but it's a probably private repository. The homepage link in the app-bridge package works.

As for the change logs it looks like they stopped publishing the CHANGELOG.MD as of 3.5.1. The only place where I can find any information regarding changes is in Slack by searching each version one by one.

If the repository is not going to be public, then there needs to be a centralized location for a verbose list of changes to exist. Having a CHANGELOG.MD is perfectly fine.

According to this comment in the partner slack, a changelog site is "on their radar", but that was 7 months ago and well before they removed the CHANGELOG.MD.

darrynten commented 1 year ago

if there was a changelog i wonder if it would mention or explain what happened to app-bridge-utils and what we need to use instead now that it's deprecated

charlesdobson commented 1 year ago

@darrynten You can import all utilities from the old @shopify/app-bridge-utils package directly through @shopify/app-bridge as of v3.6.0, like this:

import { getSessionToken } from "@shopify/app-bridge/utilities";

...

import { authenticatedFetch } from "@shopify/app-bridge/utilities";

...

import {setupModalAutoSizing} from '@shopify/app-bridge/utilities';

...

import {isMobile, isShopifyEmbedded} from '@shopify/app-bridge/utilities';
darrynten commented 1 year ago

that's fantastic thank you!

jzazove commented 6 months ago

This is fixed.