Shopify / shopify-app-bridge

https://shopify.dev/docs/api/app-bridge
85 stars 9 forks source link

App Bridge is causing all apps to hang - Server side issue? #184

Closed TheSecurityDev closed 1 year ago

TheSecurityDev commented 1 year ago

Describe the bug

App Bridge seems to be currently experiencing an issue where clicking on the navigation menu item for the app, or clicking Cancel on a Resource Picker causes the entire page to freeze. I reproduced this in multiple browsers and in multiple apps.

The entire page freezes up, and you can't run commands in the dev console. I think some kind of infinite loop is going on, or something else with the postMessage commands.

I suspect it's a server-side issue due to the fact that apps that were working before are experiencing the same issue, even in a different browser.

To Reproduce

  1. Open an embedded app.
  2. Try to click a side navigation menu item, or
  3. Open a Resource Picker and then click Cancel

Interestingly, those are the only things that I've noticed are broken. Other app bridge functionality seems to be working still.

Packages and versions

List the relevant packages you’re using, and their versions. For example:

It started happening right after I upgraded app bridge, but then I tested it on my production app that has an older version that previously worked, and it still wasn't working. Then I tried a completely different app (Judge.me) and still experienced the issue. I tried in a separate browser that wasn't even signed in before and it still didn't work.

Platform

Additional context

NextJS app with React.

I should note that I've also been noticing an issue where the Shopify mobile app navigation menu items don't always work when you click on them, and it's very frustrating. I'm wondering if the issue is related.

RienNeVaPlus commented 1 year ago

Can confirm. Seems to be tied to the NavigationMenu component; it does not happen when browsing using navigate().

hknowlton commented 1 year ago

👍 We are also seeing this issue with the Plus Wholesale Channel.

CNBorn commented 1 year ago

Can confirm seeing this issue with Shopify Audiences. Link works fine from app UI but see pages froze when clicking the navigation menu.

jfdha commented 1 year ago

We are also seeing this on all our stores, though we noticed it with our app (which hasn't had code changes pushed to it in 3 weeks) it seems to be affecting all apps on the stores.

jsanders92 commented 1 year ago

We are also seeing this in our stores due to the NavigationMenu component. Any workarounds to resolve this issue?

jfdha commented 1 year ago

Got this from Shopify support chat:

i have looked into this for you, and yes, there appears to be an ongoing incident right now with exactly what you are experiencing. our technical team is currently on this as we speak and i will provide an update to you the soonest we have any resolutions for our merchants.

So it sounds like it's being worked on.

jsanders92 commented 1 year ago

Got this from Shopify support chat:

i have looked into this for you, and yes, there appears to be an ongoing incident right now with exactly what you are experiencing. our technical team is currently on this as we speak and i will provide an update to you the soonest we have any resolutions for our merchants.

So it sounds like it's being worked on.

Thanks for looking into this with the shopify support team and updating us!

charlesdobson commented 1 year ago

Hi folks! 👋🏼

We've identified the cause and shipped a fix to production for this. Please let me know if you're still experiencing any issues! Closing this out for now.